Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure at NERSC due to basis template configuration #561

Open
weaverba137 opened this issue Jan 15, 2022 · 3 comments
Open

Test failure at NERSC due to basis template configuration #561

weaverba137 opened this issue Jan 15, 2022 · 3 comments
Assignees

Comments

@weaverba137
Copy link
Member

Nightly tests of desisim are failing due to the following (one!) error:

======================================================================
ERROR: test_qso_options (desisim.test.test_templates.TestTemplates)
Test that the QSO keyword arguments work
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/global/common/software/desi/cori/desiconda/20200801-1.4.0-spec/code/desisim/master/py/desisim/test/test_templates.py", line 256, in test_qso_options
    flux, wave, meta, objmeta = QSO(wave=self.wave, balqso=True).make_templates(
  File "/global/common/software/desi/cori/desiconda/20200801-1.4.0-spec/code/desisim/master/py/desisim/templates.py", line 2003, in __init__
    bal = BAL()
  File "/global/common/software/desi/cori/desiconda/20200801-1.4.0-spec/code/desisim/master/py/desisim/bal.py", line 27, in __init__
    balflux, balwave, balmeta = read_basis_templates(objtype='BAL')
  File "/global/common/software/desi/cori/desiconda/20200801-1.4.0-spec/code/desisim/master/py/desisim/io.py", line 948, in read_basis_templates
    infile = find_basis_template(ltype)
  File "/global/common/software/desi/cori/desiconda/20200801-1.4.0-spec/code/desisim/master/py/desisim/io.py", line 887, in find_basis_template
    raise IOError('No {} templates found in {}'.format(objtype, objfile_wild))
OSError: No bal templates found in /global/common/software/desi/cori/desiconda/20200801-1.4.0-spec/code/desisim-testdata/master/desi/spectro/templates/basis_templates/v3.0/bal_templates_*.fits

----------------------------------------------------------------------

I think it needs to look at v3.2 rather than v3.0, but I'm not sure where that is configured.

@moustakas
Copy link
Member

Sorry, I'm not sure where DESI_BASIS_TEMPLATES is configured for the nightly integration tests, either. There's this line which used to point to the v3.0 templates
https://github.com/desihub/desisim-testdata/blob/master/setup-testdata.sh
but I updated it in desihub/desisim-testdata#15.

Maybe @sbailey knows off-hand?

@marcelo-alvarez
Copy link

marcelo-alvarez commented May 24, 2023

@moustakas was this fixed by desihub/desisim-testdata#15? Nevermind, I think that PR actually caused this issue in the first place.

@weaverba137
Copy link
Member Author

@moustakas, @marcelo-alvarez did this get fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants