Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Command Parsing in Denon's stdCmd #170

Open
heinthanth opened this issue Sep 9, 2024 · 0 comments
Open

Wrong Command Parsing in Denon's stdCmd #170

heinthanth opened this issue Sep 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@heinthanth
Copy link

heinthanth commented Sep 9, 2024

Denon's stdCmd() function does not parse/split the command correctly.

To Reproduce

  1. Use cmd: "bash -c 'echo \"HELLO\"'".
  2. Try to run that task

Expected behavior

This command ["bash", "-c", "'echo "HELLO\"'"] should be executed. Instead, [ "bash", "-c", "'echo", "HELLO"' ] is executed.

Configuration or Project

scripts:
  dev:
    - "bash -c 'echo \"HELLO\"'"

Screenshots

Screenshot 2024-09-09 at 12 19 42

Setup

  • OS: macOS
  • Deno version: deno 1.46.3 (stable, release, aarch64-apple-darwin)
  • Denon version: v2.5.0

Additional context

I think stdCmd should consider quotes while splitting the command. I think this might be a good candidate (https://github.com/rgov/node-shlex)

@heinthanth heinthanth added the bug Something isn't working label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant