fix(check): compiler options from workspace members #27009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Nov 23, 2024
|
Yeah this is not for landing yet |
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
nayeemrmn
changed the title
…ber-compiler-options
dsherret
reviewed
Nov 29, 2024
| } else { | ||
| found_specifiers = true; | ||
| } | ||
| let factory = CliFactory::from_cli_options(Arc::new(cli_options)); |
There was a problem hiding this comment.
Ideally we should only be creating a single factory. Why is all this setup code necessary here?
There was a problem hiding this comment.
The factory's services used below are based on a single WorkspaceDirectory currently. I wanted to contain the changes somewhere for now but I can keep working on it.
| ConfigFlag::Path(_) => false, | ||
| ConfigFlag::Disabled => false, | ||
| }; | ||
| if is_discovered_config { |
There was a problem hiding this comment.
Why do we only do this for discovered configuration files? Can you add a comment explaining?
| .await | ||
| Ok( | ||
| main_graph_container | ||
| .check_specifiers(&specifiers_for_typecheck, None) |
There was a problem hiding this comment.
Maybe we should handle this exclusively in check_specifiers?
…ber-compiler-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24504.
Blocked by denoland/deno_config#143.
Blocked by crate updates in #27096.