Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_unit_tests::http2_test is very flaky #27154

Open
dsherret opened this issue Nov 29, 2024 · 0 comments
Open

node_unit_tests::http2_test is very flaky #27154

dsherret opened this issue Nov 29, 2024 · 0 comments
Labels
flaky a test is not reliable or determinstic

Comments

@dsherret
Copy link
Member

---- node_unit_tests::http2_test stdout ----
command /Users/runner/work/deno/deno/target/debug/deno test --config /Users/runner/work/deno/deno/tests/config/deno.json --no-lock --unstable-broadcast-channel --unstable-net -A --cert=./tests/testdata/tls/RootCA.pem /Users/runner/work/deno/deno/tests/unit_node/http2_test.ts
command cwd /Users/runner/work/deno/deno
[http2_test 000.23] Download http://localhost:4260/@types%2fnode
[http2_test 000.26] Download http://localhost:4260/undici-types
[http2_test 000.26] Download http://localhost:4260/@types/node/node-22.5.4.tgz
[http2_test 000.31] Download http://localhost:4260/undici-types/undici-types-6.19.8.tgz
[http2_test 000.59] Check file:///Users/runner/work/deno/deno/tests/unit_node/http2_test.ts
[http2_test 005.82] running 11 tests from ./tests/unit_node/http2_test.ts
[http2_test 007.85] [node/http2 client] http://localhost:4246 ... ok (2s)
[http2_test 009.85] [node/http2 client] https://localhost:4247 ... ok (2s)
[http2_test 011.88] [node/http2 client createConnection] ... ok (2s)
[http2_test 012.06] [node/http2 client GET https://www.example.com]/ ... ok (188ms)
[http2_test 012.28] [node/http2.createServer()] ...
[http2_test 012.29] Uncaught error from ./tests/unit_node/http2_test.ts FAILED
[http2_test 012.29] [node/http2.createServer()] ... cancelled (0ms)
[http2_test 012.29] [node/http2 client] write image buffer on request stream works ... cancelled (0ms)
[http2_test 012.29] [node/http2 client] write 512kb buffer on request stream works ... cancelled (0ms)
[http2_test 012.29] [node/http2 client] deno doesn't panic on uppercase headers ... cancelled (0ms)
[http2_test 012.29] [node/http2 ClientHttp2Session.socket] ... cancelled (0ms)
[http2_test 012.29] [node/http2 client] connection states ... cancelled (0ms)
[http2_test 012.29] request and response exports ... cancelled (0ms)
[http2_test 012.31] 
[http2_test 012.31]  ERRORS 
[http2_test 012.31] 
[http2_test 012.31] ./tests/unit_node/http2_test.ts (uncaught error)
[http2_test 012.31] error: (in promise) Http: Http: connection error
[http2_test 012.31]     at ext:deno_http/00_serve.ts:859:15
[http2_test 012.31]     at eventLoopTick (ext:core/01_core.js:175:7)
[http2_test 012.31] This error was not caught from a test and caused the test runner to fail on the referenced module.
[http2_test 012.31] It most likely originated from a dangling promise, event/timeout handler or top-level code.
[http2_test 012.31] 
[http2_test 012.31]  FAILURES 
[http2_test 012.31] 
[http2_test 012.31] ./tests/unit_node/http2_test.ts (uncaught error)
[http2_test 012.31] 
[http2_test 012.31] FAILED | 4 passed | 8 failed (6s)
[http2_test 012.31] 
[http2_test 012.37] error: Test failed
thread 'node_unit_tests::http2_test' panicked at tests/integration/node_unit_tests.rs:192:3:
assertion `left == right` failed: Deno should have exited cleanly
  left: Some(0)
 right: Some(1)
stack backtrace:
   0:        0x10d1e7266 - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::hcaf66bc4c0c453df
   1:        0x10d20bccb - core::fmt::write::hc9c5f1836b413410
   2:        0x10d1e2fa2 - std::io::Write::write_fmt::h5ce5bc7686de8484
   3:        0x10d1e8aa8 - std::panicking::default_hook::{{closure}}::h52c0b2f44f6107c5
   4:        0x10d1e8628 - std::panicking::default_hook::h5a6cf31501c161b2
   5:        0x10b12306b - test::test_main::{{closure}}::h3d665f637d89df05
   6:        0x10d1e9810 - std::panicking::rust_panic_with_hook::hda4640ee332466e9
   7:        0x10d1e9095 - std::panicking::begin_panic_handler::{{closure}}::haa3060694b34ea3d
   8:        0x10d1e7749 - std::sys::backtrace::__rust_end_short_backtrace::h8eb44913cfe71457
   9:        0x10d1e8cdc - _rust_begin_unwind
  10:        0x10d23d8ea - core::panicking::panic_fmt::h31edc3d6ff0aadca
  11:        0x10d23de6b - core::panicking::assert_failed_inner::had7e28e3814f0dcd
  12:        0x10d2142a6 - core::panicking::assert_failed::hd963831ec1dee0a2
  13:        0x10b09afef - integration_tests::node_unit_tests::node_unit_test::hbd288a83c64c81f7
  14:        0x10b0a3d10 - integration_tests::node_unit_tests::http2_test::hce393a6f45d5abc7
  15:        0x10b0a3cc5 - integration_tests::node_unit_tests::http2_test::{{closure}}::h97b7d5eb0be9d000
  16:        0x10ad1ac38 - core::ops::function::FnOnce::call_once::hefbc45d22c6afc5f
  17:        0x10b12763b - test::__rust_begin_short_backtrace::h93e921f893a90bb1
  18:        0x10b126ea1 - test::run_test::{{closure}}::h42576c3f690468a6
  19:        0x10b0ebb4d - std::sys::backtrace::__rust_begin_short_backtrace::hb534ca9204c87c90
  20:        0x10b0ef352 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h95ab9f9938de870a
  21:        0x10d1eed8b - std::sys::pal::unix::thread::Thread::new::thread_start::h55ff15b5f[2276](https://github.com/denoland/deno/actions/runs/12087577936/job/33709309912?pr=27141#step:43:2277)bcd
  22:     0x7ff811f681d3 - __pthread_start


failures:
    node_unit_tests::http2_test

https://github.com/denoland/deno/actions/runs/12087577936/job/33709309912?pr=27141

@dsherret dsherret added the flaky a test is not reliable or determinstic label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky a test is not reliable or determinstic
Projects
None yet
Development

No branches or pull requests

1 participant