Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR not working in deno-vite-solidjs #27148

Closed
scarf005 opened this issue Nov 29, 2024 · 3 comments
Closed

HMR not working in deno-vite-solidjs #27148

scarf005 opened this issue Nov 29, 2024 · 3 comments
Labels
upstream Changes in upstream are required to solve these issues

Comments

@scarf005
Copy link
Contributor

_20241129_231210.webm

Version: Deno 2.1.2

to reproduce

  1. run deno run -RWE npm:create-vite-extra@latest
  2. setup deno-solid
  3. run deno task dev
  4. despite on vite hmr isn't working.
@marvinhagemeister
Copy link
Contributor

Looks like an upstream issue in either solidjs or vite itself. I can't get HMR working in Node either. When I click the counter and change something else, the counter is always reset in Node. Same is true for the normal solidjs preset for Node.

Closing because it's not an issue with Deno, but an upstream issue.

@marvinhagemeister marvinhagemeister added the upstream Changes in upstream are required to solve these issues label Dec 2, 2024
@scarf005
Copy link
Contributor Author

scarf005 commented Dec 2, 2024

oh, yeah looks like solidjs has no way of preserving state between hmr according to solidjs/vite-plugin-solid#42
could you close it as not planned instead?

@marvinhagemeister
Copy link
Contributor

sure

@marvinhagemeister marvinhagemeister closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Changes in upstream are required to solve these issues
Projects
None yet
Development

No branches or pull requests

2 participants