Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): unref pending reads in readStop #27064

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(ext/node): unref pending reads in readStop #27064

wants to merge 11 commits into from
+23 −1

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Nov 25, 2024 •
edited
Loading

Fixes @inquirer/prompts and @clack/prompts.

Fixes #26395
Fixes #26403
Fixes #27129

@littledivy littledivy marked this pull request as ready for review November 26, 2024 11:14
nathanwhit
nathanwhit approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@littledivy @bartlomieju @nathanwhit