Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2.9] Exception thrown when attempting to GetIntervisibilityReport. #88

Closed
rurounijones opened this issue Mar 11, 2021 · 4 comments
Closed

Comments

@rurounijones
Copy link

Calling ElevationService.GetIntervisibilityReport in release [0.2.9] results in the following runtime exception

System.MissingMethodException: Method not found: 'Void NetTopologySuite.Geometries.LineString..ctor(GeoAPI.Geometries.Coordinate[])'.
   at DEM.Net.Core.GeometryService.ParseGeoPointAsGeometryLine(GeoPoint[] points)
   at DEM.Net.Core.ElevationService.GetIntervisibilityReport(GeoPoint source, GeoPoint target, DEMDataSet dataSet, Boolean downloadMissingFiles, Double sourceVerticalOffset, Double targetVerticalOffset, InterpolationMode interpolationMode)

I believe the issue is that the code in GeometryService is using new Coordinate without specifying if it is a GeoAPI Coordinate or a NetTopologySuite one and the code is picking the wrong one at runtime.

I believe this issue has been fixed in the master branch by the removal of GeoAPI as part of b3d755f

Is there a planned timeline for the next release of DEM.Net that contains this change?

Thanks for the great work and great library.

@xfischer
Copy link
Member

Hi @rurounijones, thanks !

I'll try to make a new release by the end of the week. Thanks for reporting this :)

@rurounijones
Copy link
Author

Wunderbar, thanks very much!

@xfischer
Copy link
Member

xfischer commented Mar 12, 2021

@rurounijones Can you test now ?

[0.3.0] version has been released to NuGet.

@xfischer xfischer reopened this Mar 12, 2021
@xfischer xfischer pinned this issue Mar 12, 2021
@rurounijones
Copy link
Author

No exceptions being thrown in [0.3.0]

Thanks for the quick support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants