Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python, rust): add drop column operation [BLOCKED] #2710

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat(python, rust): add drop column operation [BLOCKED] #2710

wants to merge 9 commits into from

Commits on Jul 30, 2024

  1. prepare drop columns skeleton

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    99bb2eb View commit details
    Browse the repository at this point in the history

  2. functional drop columns

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    eb54143 View commit details
    Browse the repository at this point in the history

  3. remember columns that do not exist, add option to raise then

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    067ff56 View commit details
    Browse the repository at this point in the history

  4. catch also root columns not there

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d8ea776 View commit details
    Browse the repository at this point in the history

  5. add tests

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4f53d87 View commit details
    Browse the repository at this point in the history

  6. fmt

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6dc71e3 View commit details
    Browse the repository at this point in the history

  7. fmt

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c3ca4c3 View commit details
    Browse the repository at this point in the history

  8. Update crates/core/src/operations/drop_column.rs 

    Co-authored-by: Guilhem de Viry <[email protected]>
    @ion-elgreco @guilhem-dvr
    ion-elgreco and guilhem-dvr committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    da58838 View commit details
    Browse the repository at this point in the history

  9. check if column mapping is enabled

    @ion-elgreco
    ion-elgreco committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dcca23c View commit details
    Browse the repository at this point in the history