-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update golden files for FFI invalid handle tests #346
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but wondering if this really means we can only support the latest rustc with this sort of error message testing? Ideally I think we would want to have an MSRV that's somewhat old but that would mean all these error would change?
looks like |
Depends on the compiler version, methinks. @zachschuermann has a good point. Or maybe we just run once in a while like this, because they're anyway only verifying that the compiler blocks users attempting Bad Things. Even if the compiler ever failed to block them, they're still doing it wrong and should stop. |
@scovich yea maybe the simplest thing for now is to try to freeze the golden file tests to run against a specific version of rustc? wonder if that's possible |
strawman for now: can we just pin the rustc version only for these tests? |
At some point a compiler upgrade started producing more verbose diagnostics, but golden files were never updated to match. Update them now.