Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools to address setuptools#4483 #1064

Closed
wants to merge 3 commits into from
Closed

Conversation

mikealfare
Copy link
Contributor

Problem

setuptools released 71.0.0 and 71.0.1 last night which contains a breaking change. This is blocking our CI. See pypa/setuptools#4483 for more information.

Solution

  • create a separate build-requirements.txt file to isolate build dependencies
  • pin setuptools~=70.0 in this file
  • reference this file in dev-requirements.txt for backwards compatibility
  • install from this file in workflows instead of running pip install --upgrade setuptools ...

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 18, 2024
@mikealfare mikealfare requested a review from a team as a code owner July 18, 2024 14:13
@cla-bot cla-bot bot added the cla:yes label Jul 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@@ -0,0 +1,5 @@
bumpversion~=0.6.0
setuptools~=70.0
twine~=5.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were installing this directly and upgrading, so we never actually used 4.0. 4.0 is also broken, see pypa/twine#977. From the post in there, the date of the fix, and the dates of the releases, the fix was released as part of 5.0.

@mikealfare
Copy link
Contributor Author

We don't actually need this

@mikealfare mikealfare closed this Jul 18, 2024
@mikealfare mikealfare deleted the pin-setuptools branch September 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant