Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap source dist install + check and wheel install + check in build packages step in main.yml #10463

Merged
merged 14 commits into from
Jul 18, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 18, 2024

resolves #N/A

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jul 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk changed the title remove upper pin on packaging pin setuptools Jul 18, 2024
@MichelleArk MichelleArk force-pushed the fix-setuptools-install branch from d90d33e to ccca813 Compare July 18, 2024 16:55
@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Jul 18, 2024
@MichelleArk MichelleArk changed the title pin setuptools swap source dist install + check and wheel install + check in build packages step in main.yml Jul 18, 2024
@MichelleArk MichelleArk added backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.1.latest backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch labels Jul 18, 2024
@MichelleArk MichelleArk merged commit 0395264 into 1.3.latest Jul 18, 2024
36 of 38 checks passed
@MichelleArk MichelleArk deleted the fix-setuptools-install branch July 18, 2024 18:12
@MichelleArk MichelleArk removed backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch backport 1.1.latest labels Jul 18, 2024
@MichelleArk MichelleArk added backport 1.2.latest This PR will be backported to the 1.2.latest branch and removed backport 1.2.latest This PR will be backported to the 1.2.latest branch labels Jul 18, 2024
Copy link
Contributor

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-10463-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0395264c57280a931715b04b314745dc75f2e4d2
# Push it to GitHub
git push --set-upstream origin backport-10463-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-10463-to-1.2.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.2.latest This PR will be backported to the 1.2.latest branch cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants