Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires a breaking change update introduced by upgrading to Workbox 5 #5

Open
jackfruit2 opened this issue Aug 14, 2022 · 0 comments

Comments

@jackfruit2
Copy link

jackfruit2 commented Aug 14, 2022

A breaking change update is required to this module to ensure that its compatible with Workbox 5.

See the following error:

Creating an optimized production build...
Failed to compile.

Please check your GenerateSW plugin configuration:
[WebpackGenerateSW] 'navigateFallbackBlacklist' property is not expected to be here. Did you mean property 'navigateFallbackAllowlist'?

I created a PR that fixes the issue in the is module that can be found here:
#4

Once I made the change from navigateFallbackBlacklist -> navigateFallbackDenylist it allows the module to be used with v5 of Workbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant