Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose writer functions #71

Open
zcourts opened this issue Sep 30, 2024 · 0 comments
Open

Expose writer functions #71

zcourts opened this issue Sep 30, 2024 · 0 comments

Comments

@zcourts
Copy link

zcourts commented Sep 30, 2024

Would you be open to some refactor of the functions in

https://github.com/databendlabs/opensrv/blob/main/mysql/src/writers.rs#L63

ErrorKind doesn't have all the MySQL error codes, for example ER_NO_SUCH_DB

Instead of doing a PR for each one that pops up I was thinking the functions could be refactored to accept the u16 and the PacketWriter made public instead of (create) so the fns can be called outside the crate and have a ref to pass in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant