Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String literals must not be treated as separate types #145

Open
rgommers opened this issue Dec 15, 2021 · 1 comment
Open

String literals must not be treated as separate types #145

rgommers opened this issue Dec 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rgommers
Copy link
Member

Strings are things like column names; there is no point treating those as separate types, it gives a huge amount of pollution in the generated type annotations. Example: typing/pandas.core.frame.py has 10,000+ lines for __getitem__/__setitem__ overloads.

Related, issue to make results more interpretable: gh-71

@rgommers rgommers added the bug Something isn't working label Dec 15, 2021
@kgryte
Copy link
Contributor

kgryte commented Dec 15, 2021

This issue seems more relevant for the dataframe analysis. For array analysis, treating strings as unique was useful to see which kwarg values were provided by downstream libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants