Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid input is silently discarded #107

Open
komu opened this issue Jan 29, 2021 · 3 comments
Open

Invalid input is silently discarded #107

komu opened this issue Jan 29, 2021 · 3 comments

Comments

@komu
Copy link

komu commented Jan 29, 2021

I have an existing time in the picker, then open the picker and input invalid hour:

Screenshot 2021-01-29 at 12 45 54

Nothing is indicated as being invalid and Set button is enabled. When I click Set, the valid parts of my input (minutes) are set to new values, but the invalid hours are not:

Screenshot 2021-01-29 at 12 46 16

Similarly if I would have entered 13:65 as input, the valid part (hours) would have been copied, but the minutes not. Same happens if either hours or minutes are left completely blank.

I would expect that Set is disabled when the input in the dialog is not valid.

@danielmoncada
Copy link
Owner

closing.. stale

@komu
Copy link
Author

komu commented May 10, 2023

Then again, the problem still seems to be there.

@danielmoncada
Copy link
Owner

@komu okay, I'll re-open. feel free to make a PR to fix it 👍

@danielmoncada danielmoncada reopened this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants