ci: add GitHub Workflow for building and pushing container-images #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Dec 22, 2021
There was a problem hiding this comment.
there is a lot of duplication of code this can be reduced take a look at https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/ could be considered as an enhancement if it needs more time to figure out.
That is a good idea, but it would need some experimenting before I feel comfortable doing it that way. Created #24 for tracking. |
Madhu-1
approved these changes
Dec 22, 2021
yati1998
approved these changes
Dec 22, 2021
The container images should get pushed to quay.io after a PR has been merged. This currently builds the container images for all the architectures that the golang base container and Docker Actions support. Signed-off-by: Niels de Vos <[email protected]>
Test building container images, so that Mergify can require `build_controller` and `build_sidecar` as CI jobs. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
workflows/build-push
branch
from
a4da2a3 to
d1129b7
Compare
Rakshith-R
referenced
this pull request
in Rakshith-R/kubernetes-csi-addons
Jan 31, 2022
…-to-release-4.10 [release-4.10] Bug 2043406: sync upstream main branch to downstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two CI jobs are added:
Test building container images, so that Mergify can require
build_controllerandbuild_sidecaras CI jobs.The container images should get pushed to quay.io after a PR has been
merged. This currently builds the container images for all the
architectures that the golang base container and Docker Actions support.