Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto reclaim storage based on the storageclass/namespace #557

Open
Madhu-1 opened this issue Apr 30, 2024 · 2 comments
Open

Auto reclaim storage based on the storageclass/namespace #557

Madhu-1 opened this issue Apr 30, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Madhu-1
Copy link
Member

Madhu-1 commented Apr 30, 2024

The current way of annotating the PVC, namespace is not so useful because the customer needs to annotate the resources and doesn't provide any option for the admin if someone wants to auto reclaim the space, Provide an option set at the csi-addon controller that exposes some configurations to say auto reclaim space for the PV created by this driver.

Example: add support to , separate driver names which can auto reclaim to https://github.com/csi-addons/kubernetes-csi-addons/blob/main/deploy/controller/csi-addons-config.yaml or some other way.

The above is helpful for the PV key rotation as well.

Admins deploying the operator need not worry about security or storage if it is unused and unannotated.

@nixpanic nixpanic added the enhancement New feature or request label May 1, 2024
@nixpanic
Copy link
Collaborator

nixpanic commented May 1, 2024

@Madhu-1: Instead of an option per driver, it would probably make more sense to have an option per StorageClass? That way it would be possible for admins to enable/disable auto-reclaim a little more granular.

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 2, 2024

@Madhu-1: Instead of an option per driver, it would probably make more sense to have an option per StorageClass? That way it would be possible for admins to enable/disable auto-reclaim a little more granular.

Yes that is also one option and we need to add EnqueueRequestsFromMapFunc in our PVC controller to watch for storageclass and namespace objects and reconcile all the PVC's or something like that which will help us to reconcile all the PVC's if the annotation is added/deleted/updated on the storageclass/namespace

@Madhu-1 Madhu-1 changed the title Auto reclaim storage based on the drivers Auto reclaim storage based on the storageclass/namespace May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants