-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify app-interact chapter #76
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build fails because you made some indentation errors in config.yaml
. However, I reckon its format isn't the most user-friendly. I made a comment explaining how to fix them.
I skimmed through the overall structure and pointed out a few things to change. I'll look deeper into the content once the website can be built (I also suggested how to do that). In addition to these changes, modify your commit message to:
chapter/app-interact: Restructure the chapter according to OpenEducationHub methodology
<add a description here>
4fa948e
to
a6d7dcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is so huge that it's difficult to load. Remove the output
folder altogether and add it to the global .gitignore
file. This will reduce the size of your diff significantly. Then I'll return with a more in-depth review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the "Practice" sections from the reading/
sections to each task
's readme.
a6d7dcf
to
2f40d33
Compare
…ionHub methodology Add app-interact to OpenEducation methodology Signed-off-by: Sorin Birchi <[email protected]>
2f40d33
to
20daa03
Compare
Published at https://cs-pub-ro.github.io/operating-systems/76/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lab content looks alright. Perhaps you can rename it to something more accurate such as "Investigate Applications". Also see my suggestions below inline.
- You also need to move the slides from
content/chapters/app-interact/lecture
tochapters/app-interact/<inidivual-subchapters>/slides/
- Add the following line to the end of each task's
README.md
: "If you're having difficulties solving this task, go through [this](link to the relevant section in reading/) reading material." - Mention the path to the support files in each task so students can get there more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this task to guides/
because there's nothing for students to do individually and the README.md
gives a complete rundown of what they're supposed to do.
Each worker will receive 2 characters instead of one, defining an interval to search. | ||
For example, the first worker will receive `a` and `f`, meaning it will brute-force passwords starting with `a`, `b`, `c`, `d`, `e`, or `f`, the second `g` - `l`, and so on. | ||
|
||
Check that the `worker` function is indeed called from different worker processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that the `worker` function is indeed called from different worker processes. | |
Check that the `worker()` function is indeed called from different worker processes. |
|
||
Check that the `worker` function is indeed called from different worker processes. | ||
One simple way to do this is to print out the current process ID at the beginning of the function. | ||
To get the current process ID, use the `getpid` function from the `os` module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get the current process ID, use the `getpid` function from the `os` module. | |
To get the current process ID, use the `getpid()` function from the `os` module. |
Prerequisite Checklist
Description of changes