Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify app-interact chapter #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SorinAlexB
Copy link

@SorinAlexB SorinAlexB commented Aug 5, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

@SorinAlexB SorinAlexB added the needs-rendering The PR makes changes to the website that need to be rendered label Aug 5, 2024
@SorinAlexB SorinAlexB requested a review from teodutu August 5, 2024 19:19
@github-actions github-actions bot added area/content Content (Markdown) update area/media Update to media content area/questions Update to questions content area/reading Update to reading content area/tasks Update to tasks labels Aug 6, 2024
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails because you made some indentation errors in config.yaml. However, I reckon its format isn't the most user-friendly. I made a comment explaining how to fix them.

I skimmed through the overall structure and pointed out a few things to change. I'll look deeper into the content once the website can be built (I also suggested how to do that). In addition to these changes, modify your commit message to:

chapter/app-interact: Restructure the chapter according to OpenEducationHub methodology

<add a description here>

chapters/app-interact/arena/reading/arena.md Outdated Show resolved Hide resolved
chapters/app-interact/dbus/reading/dbus.md Outdated Show resolved Hide resolved
content/chapters/app-interact/.gitignore Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
@SorinAlexB SorinAlexB force-pushed the translate_app-interact branch from 4fa948e to a6d7dcf Compare September 11, 2024 11:38
@github-actions github-actions bot added the kind/new New content / item label Sep 11, 2024
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is so huge that it's difficult to load. Remove the output folder altogether and add it to the global .gitignore file. This will reduce the size of your diff significantly. Then I'll return with a more in-depth review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the "Practice" sections from the reading/ sections to each task's readme.

@SorinAlexB SorinAlexB force-pushed the translate_app-interact branch from a6d7dcf to 2f40d33 Compare September 15, 2024 09:06
…ionHub methodology

Add app-interact to OpenEducation methodology

Signed-off-by: Sorin Birchi <[email protected]>
@SorinAlexB SorinAlexB force-pushed the translate_app-interact branch from 2f40d33 to 20daa03 Compare September 15, 2024 09:14
@SorinAlexB SorinAlexB requested a review from teodutu September 15, 2024 09:14
@github-actions github-actions bot added the kind/improve Improve / Update existing content / item label Sep 15, 2024
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Sep 18, 2024
Copy link

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lab content looks alright. Perhaps you can rename it to something more accurate such as "Investigate Applications". Also see my suggestions below inline.

  • You also need to move the slides from content/chapters/app-interact/lecture to chapters/app-interact/<inidivual-subchapters>/slides/
  • Add the following line to the end of each task's README.md: "If you're having difficulties solving this task, go through [this](link to the relevant section in reading/) reading material."
  • Mention the path to the support files in each task so students can get there more easily.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this task to guides/ because there's nothing for students to do individually and the README.md gives a complete rundown of what they're supposed to do.

Each worker will receive 2 characters instead of one, defining an interval to search.
For example, the first worker will receive `a` and `f`, meaning it will brute-force passwords starting with `a`, `b`, `c`, `d`, `e`, or `f`, the second `g` - `l`, and so on.

Check that the `worker` function is indeed called from different worker processes.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Check that the `worker` function is indeed called from different worker processes.
Check that the `worker()` function is indeed called from different worker processes.


Check that the `worker` function is indeed called from different worker processes.
One simple way to do this is to print out the current process ID at the beginning of the function.
To get the current process ID, use the `getpid` function from the `os` module.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To get the current process ID, use the `getpid` function from the `os` module.
To get the current process ID, use the `getpid()` function from the `os` module.

@cosmin1805 cosmin1805 mentioned this pull request Nov 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/content Content (Markdown) update area/media Update to media content area/questions Update to questions content area/reading Update to reading content area/tasks Update to tasks kind/improve Improve / Update existing content / item kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants