Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onUserError not implemented #474

Open
om26er opened this issue Feb 10, 2020 · 2 comments
Open

onUserError not implemented #474

om26er opened this issue Feb 10, 2020 · 2 comments
Assignees

Comments

@om26er
Copy link
Contributor

om26er commented Feb 10, 2020

The ABJ does not implement the onUserError, while we have the signature on the Session class, we don't really hook that to anything.

public OnUserErrorListener addOnUserErrorListener(OnUserErrorListener listener) {

@oberstet
Copy link
Contributor

ok, yeah, we actually fire the listeners collected in addUserErrorListener;) there will be multiple locations where we have to add firing the hook .. best in probably to look at the twisted ABPy and component ABPy implementations ..

@om26er om26er self-assigned this Feb 10, 2020
@om26er
Copy link
Contributor Author

om26er commented Feb 10, 2020

It seems ABPy Component API does not implement/expose onUserError. Also for Java, it may make sense to give the "user error" in the exceptionally clause of the CompletableFuture. That way developers will know the context where the issue is coming and subsequently better handle it.

Providing errors in a separate, context-independent mechanism is likely to make the API complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants