Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler 4844 prove method #96

Open
kevaundray opened this issue Aug 20, 2024 · 3 comments
Open

Simpler 4844 prove method #96

kevaundray opened this issue Aug 20, 2024 · 3 comments

Comments

@kevaundray
Copy link
Contributor

Previously I was against changing the 4844 code due to it already been auditted, however the code has changed quite a lot since we added 7594 methods, so it may be feasible to change that code given it will likely need to be auditted again.

@kevaundray
Copy link
Contributor Author

Testing the difference:

BenchmarkOpenMonomial-10    	     100	  10691245 ns/op	  406979 B/op	     180 allocs/op
BenchmarkOpenLagrange-10    	     124	  10653541 ns/op	  799451 B/op	     163 allocs/op

Lagrange is what we currently do and monomial is the change proposed. The difference here is 10.69 vs 10.65 milliseconds

@kevaundray
Copy link
Contributor Author

Strangely open monomial uses ~49% less memory

@kevaundray
Copy link
Contributor Author

Higher level benchmarks have been collected in #97, #98, #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant