Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synth. dataset: remove duplicated method invocations #124

Open
KatGarmash opened this issue Feb 1, 2021 · 0 comments
Open

Synth. dataset: remove duplicated method invocations #124

KatGarmash opened this issue Feb 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@KatGarmash
Copy link
Member

Why

We observed the following case of function invocations in the original code used for synthtic dataset: an method extrMethod(); is called from different places (different methods) within the same class. This is a case of code duplication. It may be that the reason extrMethod was defined as a separate method is precisely because of code duplication, and not because it is a semantically cohesive piece of code which can serve as a good example of ExtractMethod refactoring.

What we want

Eliminate the factor of code duplication in our synthetic dataset on LM/EM.

Proposed solution

Simplest and least nuanced solution: do not inline methods that are invoked more than once with a give class.

@KatGarmash KatGarmash added the enhancement New feature or request label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant