Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validation into the message handlers #2275

Closed
insumity opened this issue Sep 16, 2024 · 1 comment
Closed

Move validation into the message handlers #2275

insumity opened this issue Sep 16, 2024 · 1 comment
Labels
good first issue Good for newcomers scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run

Comments

@insumity
Copy link
Contributor

Problem

Currently, we validate messages with ValidateBasic (e.g., see MsgAssignConsumerKey). However, this way of validating is deprecated. This issue is a reminder that we should move validation to the message handlers (e.g., in AssignConsumerKey).
@insumity insumity added status: waiting-triage This issue/PR has not yet been triaged by the team. and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Sep 16, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 16, 2024
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 17, 2024
@mpoke mpoke added scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run good first issue Good for newcomers labels Sep 17, 2024
@mpoke
Copy link
Contributor

mpoke commented Sep 17, 2024

Closing as duplicate. See #2149

@mpoke mpoke closed this as completed Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Sep 17, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@insumity @mpoke