Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated revision number information in the consumer-addition proposal #1269

Open
Tracked by #2382
AaronKutch opened this issue Sep 7, 2023 · 0 comments
Open
Tracked by #2382
Labels
scope: UI Addressing UX changes and improvements to user interface type: bug Issues that need priority attention -- something isn't working

Comments

@AaronKutch
Copy link

When trying to launch a consumer chain on testnet, we made a last minute change to the chain id which added on -testnet-1, which I didn't believe would possibly break anything. However, I discovered that Hermes could not connect the chains for some reason, and after a lot of hair tearing out and chasing why certain chain ids were causing obscure trusted header mismatch errors, I found that the "revision_number": 0 subfield in the consumer proposal clashed with the revision number associated with the "chain_id" . Different things were using different revision numbers and making the tendermint clients fundamentally incompatible.

Either this field should be deduplicated, or the proposal command should have some kind of check to prevent revision number disagreements.

@AaronKutch AaronKutch added type: bug Issues that need priority attention -- something isn't working status: waiting-triage This issue/PR has not yet been triaged by the team. labels Sep 7, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 7, 2023
@mpoke mpoke added S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability scope: UI Addressing UX changes and improvements to user interface and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Sep 7, 2023
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 7, 2023
@mpoke mpoke moved this from 📥 F2: Todo to 🤔 F1: Investigate in Cosmos Hub Sep 14, 2023
@mpoke mpoke added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Apr 11, 2024
@mpoke mpoke removed status: waiting-triage This issue/PR has not yet been triaged by the team. S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability labels Sep 17, 2024
@mpoke mpoke moved this from 🤔 F1: Investigate to 📥 F2: Todo in Cosmos Hub Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: UI Addressing UX changes and improvements to user interface type: bug Issues that need priority attention -- something isn't working
Projects
Status: 📥 F2: Todo
Development

No branches or pull requests

2 participants