SDK 50 upgrade

[faddat]

Problem

Given the improvements to node performance in SDK 50, it makes sense for consumer chains to upgrade to 50.

Closing criteria

A single PR is submitted to a upgrade feature branch, which upgrades the repository in one go against that branch to prevent problems midstream with compatibility of different pieces of code that live in this repository.

Problem details

Now that IBC is upgraded, this should be relatively straightforward.

As long as the informal team thinks that it's appropriate, the notional team would like to complete this upgrade, as the notional team is attempting to ship various pieces of work with SDK 50.

Tasks

Beta Give feedback

1. spike: upgrade ICS to SDK 0.50 and IBC 8 (spike/v50-upgrade branch)
2. refactor PutUnbondingOnHold handling #1045
   S: KTLO scope: cosmos-sdk type: refactoring type: tech-debt +4
   
3. doc: create documentation for ICS v5.x #1329
   scope: consumer scope: docs scope: provider +3
   
4. create a guideline for future ICS upgrades #1330
   scope: docs type: tech-debt +2
   
5. upgrade CometMock to Comet 0.38 Upgrade CometMock to v0.38 informalsystems/CometMock#62
6. upgrade integration testing framework for v50 #1349
   S: KTLO scope: testing type: refactoring +3
   
7. update consumer app.go to v50 #1352
   S: KTLO scope: testing type: tech-debt +3
   
8. update consumer-democracy app.go to v50; update code #1359
   +0
   
9. update sovereign app.go to v50 #1356
   +0
   
10. remove governance equivocation handlers on provider #1353
    S: KTLO dependencies scope: cosmos-sdk +3
    
11. add Tx/Query handlers for submit-proposal in v50 (deprecate submit-legacy-proposal) #1361
    S: KTLO scope: cosmos-sdk type: tech-debt +3
    
12. move ICS params from global param store to ICS param store #1378
    S: KTLO scope: cosmos-sdk type: feature-request +3
    
13. enable & refactor e2e tests #1380
    S: KTLO scope: cosmos-sdk scope: testing type: tech-debt +4
    
14. add msg server for param updates on provider and consumer #1780
    api-breaking good first issue scope: cosmos-sdk +3
15. add migrations for ICS v5 consumers (cosmos-sdk v50) #1818
    scope: consumer scope: cosmos-sdk scope: provider state-machine-breaking +4

[mpoke]

@faddat Thanks for opening the issue.

Given the improvements to node performance in SDK 50, it makes sense for consumer chains to upgrade to 50.

I completely agree.

As long as the informal team thinks that it's appropriate, the notional team would like to complete this upgrade, as the notional team is attempting to ship various pieces of work with SDK 50.

Thanks for the offer, but we are handling this upgrade internally. We'll let you know if we encounter any problems.

[mpoke]

Now that IBC is upgraded

Note that the ETA for the IBC release with SDK 0.50 is end of September. The plan is to also upgrade ICS by then.

[faddat]

Yep, it will take some time to fully finish the IBC release. Prior to that we've been working on various upgrades -- * interchaintest * ibc-apps * wasmd ICT and IBC are done enough to begin work on ICS, if you'd like. Since we'll be supporting other teams in this, it is likely that we'll just begin the work, but please feel no need for our team to "own" that work.

…

On Wed, Aug 30, 2023 at 12:26 AM Marius Poke ***@***.***> wrote: Now that IBC is upgraded Note that the ETA for the IBC release with SDK 0.50 is end of September. The plan is to also upgrade ICS by then. — Reply to this email directly, view it on GitHub <#1246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWPVCIHBSKJTVEKM7WAWIDXXYJ3JANCNFSM6AAAAAA4CJXTZI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jtieri]

hello, i was curious if this was still prioritized for Q1?

interchaintest is blocked on introducing ICS support to its main branch (which currently makes use of ibc-go v8 and sdk v0.50.0) until then so figured i would check in on the current progress/prioritization

[mpoke]

hello, i was curious if this was still prioritized for Q1?

interchaintest is blocked on introducing ICS support to its main branch (which currently makes use of ibc-go v8 and sdk v0.50.0) until then so figured i would check in on the current progress/prioritization

Hi @jtieri. Yes, we plan to cut an alpha release soon.

[MSalopek]

Completed a while ago, closing.

Releases:

• https://github.com/cosmos/interchain-security/releases/tag/v5.1.0
• https://github.com/cosmos/interchain-security/releases/tag/v5.0.0