refactor: update transfer to use runtime.Environment #7615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
requested review from
AdityaSripal,
damiannolan,
srdtrk,
chatton,
DimitrisJim and
gjermundgaraba
as code owners
bznein
commented
Dec 2, 2024
| @@ -459,7 +459,9 @@ func NewSimApp( | |||
| // since fee middleware will wrap the IBCKeeper for underlying application. | |||
| // NOTE: the Transfer Keeper's ICS4Wrapper can later be replaced. | |||
| app.TransferKeeper = ibctransferkeeper.NewKeeper( | |||
| appCodec, runtime.NewKVStoreService(keys[ibctransfertypes.StoreKey]), app.GetSubspace(ibctransfertypes.ModuleName), | |||
| appCodec, | |||
| runtime.NewEnvironment(runtime.NewKVStoreService(keys[ibctransfertypes.StoreKey]), logger.With(log.ModuleKey, "x/transfer")), | |||
There was a problem hiding this comment.
Here, and elsewhere, not sure if x/transfer is right. Just followed what happened in other PRs
There was a problem hiding this comment.
I think "x/ibc-transfer" should be good
bznein
changed the title
|
@damiannolan this is ready for review. I think the only failing E2Es are the same failing on the base PR |
DimitrisJim
approved these changes
Dec 6, 2024
DimitrisJim
reviewed
Dec 6, 2024
Co-authored-by: DimitrisJim <[email protected]>
|
|
@damiannolan I guess you can take over this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opened to trigger e2e
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.