refactor: update icahost to use runtime.Environment #7600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
commented
Nov 25, 2024
Comment on lines
46
to
54
| // res, err := m.QueryRouterService.Invoke(ctx, &abci.QueryRequest{ | ||
| // Path: query.Path, | ||
| // Data: query.Data, | ||
| // }) | ||
|
|
||
| res, err := route(ctx, &abci.QueryRequest{ | ||
| res, err := m.QueryRouterService.Invoke(ctx, &cmtservice.ABCIQueryRequest{ | ||
| Path: query.Path, | ||
| Data: query.Data, | ||
| }) |
There was a problem hiding this comment.
Tried using both abci.QueryRequest and cmtservice.ABCIQueryRequest here but no luck, seems like neither are registered within the query router service.
I'm guessing we may need to do some funky string parsing to transform the service path to a type url and then decode bytes into a stub or something.
Maybe we could also extend the module query safe msg with regular proto any or msgs and deprecate the current approach. But it would be good to not break cross chain backwards compat
damiannolan
force-pushed
the
damian/icahost-runtime-env
branch
from
5789422 to
8d114c6
Compare
damiannolan
force-pushed
the
damian/icahost-runtime-env
branch
from
8d114c6 to
68be8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates icahost submodule to use
runtime.Environment.Removes
storeService,msgRouterServiceandqueryRouterServicein favour of embeddedappmodule.Environment.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.