chore: cleanup v2 #922
Open
chore: cleanup v2 #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Mar 26, 2024
Comment on lines
-11
to
-14
| free chan int | ||
| nodes []Node | ||
|
|
||
| poolId uint64 |
There was a problem hiding this comment.
whats the reason for this removal?
There was a problem hiding this comment.
I can't see any usage of it, only sync.Pool
tac0turtle
reviewed
Mar 26, 2024
Comment on lines
+114
to
+117
| // var keyBz bytes.Buffer | ||
| // keyBz.Write([]byte(node.StoreKey)) | ||
| // keyBz.Write(node.Key) | ||
| // key := keyBz.Bytes() |
There was a problem hiding this comment.
I am working on passing tests, need to cleanup the test codes
tac0turtle
approved these changes
Mar 26, 2024
|
Should we merge this or close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.