fix: Ensure RFC dates between years 0001 and 0099 are parsed correctly #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: confio/cosmjs-types#89 |
|
This change, combined with the fact we no longer allow empty/unset fields in cosmjs-types means that this: must be addressed by no longer treating the timestamp as optional. |
| function decodeCommitSignature(data: RpcSignature): CommitSignature { | ||
| return { | ||
| blockIdFlag: decodeBlockIdFlag(data.block_id_flag), | ||
| validatorAddress: data.validator_address ? fromHex(data.validator_address) : undefined, | ||
| timestamp: decodeOptionalTime(data.timestamp), | ||
| timestamp: data.timestamp ? fromRfc3339WithNanoseconds(data.timestamp) : undefined, |
There was a problem hiding this comment.
wanna run this past @ethanfrey who brought up the original issue that that hacky decodeOptionalTime() was supposed to solve?
webmaster128
approved these changes
Nov 30, 2023
|
Released in 0.32.1 – thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where an RFC3339 Date like
0001-01-01T00:00:00Z(which is used as the default/empty/ value inCommitSig.TimestampwhenBlockIdFlagisABSENT) was parsed as1901-01-01T00:00:00Zdue to the wayDate.UTC()treats years 0 to 99.This led to incorrect timestamps being generated.
Unit test has been added.