Improve Admin UI for mobile #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
from
61999a2 to
929699f
Compare
Fajfa
force-pushed
the
2023.3.x
branch
2 times, most recently
from
77f8765 to
7254628
Compare
Fajfa
requested changes
Sep 4, 2023
client/web/admin/src/components/Authclient/CAuthclientEditorInfo.vue
Outdated
Show resolved
Hide resolved
| -d grant_type=client_credentials \ | ||
| -d scope='profile api' \ | ||
| -u {{ resource.resourceID }}:{{ secret || 'PLACE-YOUR-CLIENT-SECRET-HERE' }} | ||
| curl -X POST {{ curlURL }} \ |
There was a problem hiding this comment.
This has to be misaligned since its a pre, check before and after this change and you'll see what I mean
| @@ -5,20 +5,16 @@ | |||
| > | |||
| <c-content-header | |||
| :title="title" | |||
| class="mb-2 jfd" | |||
There was a problem hiding this comment.
Oops😂 testing oversight. Will fix.
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
from
d27ca85 to
3323331
Compare
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
from
d073c07 to
a01a345
Compare
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
from
4dd0d2e to
9274c86
Compare
Fajfa
approved these changes
Oct 16, 2023
| @@ -4,132 +4,126 @@ | |||
| data-test-id="card-route-edit" | |||
| header-bg-variant="white" | |||
| footer-bg-variant="white" | |||
| footer-class="d-flex flex-wrap gap-3" | |||
|
Two small issues to address otherwise lgtm:
|
Fajfa
approved these changes
Oct 25, 2023
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
from
b39667a to
d447b56
Compare
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
2 times, most recently
from
63d1c6e to
4dea54e
Compare
EmmyMay
force-pushed
the
2023.3.x-fix-admin-mobile-ui
branch
from
4dea54e to
5f88e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR
Closes #1162