Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on echo/curl/sha256sum for the builder #2

Open
karalabe opened this issue Mar 17, 2020 · 0 comments
Open

Don't depend on echo/curl/sha256sum for the builder #2

karalabe opened this issue Mar 17, 2020 · 0 comments
Labels
area:devops Supporting infrastructure work good first issue Good for newcomers help wanted Extra attention is needed

Comments

@karalabe
Copy link
Member

To build the Android package (yarn run android), we pull in a remote .aar binary as a first build step (you can manually do it with yarn run android-archive). The code doing this is at https://github.com/coronanet/rn-coronanet/blob/master/package.json#L10 .

This is a bit icky as it relies on the availability of echo, curl, and sha256sum, which may not be installed; will definitely not work on Windows; and not sure if the pipes and logical groupings work in macos and/or non-bash.

Would be nice to replace this with a .js code (?) that does the equivalent, without requiring any external dependencies.

@karalabe karalabe added good first issue Good for newcomers help wanted Extra attention is needed area:devops Supporting infrastructure work labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:devops Supporting infrastructure work good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant