Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Layout not working for iPhone SE (1st gen) and similar sizes #2998

Open
Pe-te opened this issue Jun 23, 2021 · 4 comments
Open

Layout not working for iPhone SE (1st gen) and similar sizes #2998

Pe-te opened this issue Jun 23, 2021 · 4 comments
Labels
enhancement Improvement of an existing feature in review Moderators are investigating how to best proceed with the issue

Comments

@Pe-te
Copy link

Pe-te commented Jun 23, 2021

Hi folks, the app seems designed for some bigger device, but there are still a lot of people who use the older and smaller phones.

The margins are huge, images and texts are huge, and you have to scroll to see anything.

Would be great if you can spend some energy looking into it.

Not durr what you see on a big screen, but would at least expect to see the two big tiles „Risiko“ and „Digitaler Impfnachweis“ completely when I start the app.

Inside the „Digitaler Impfnachweis“ it would be great to see the valid until date without scrolling. Or maybe even the name.

Are you also working on Covpass? Have the same problems there, huge margins and everything needs scrolling to be visible.

@jucktnich
Copy link

I generally do support this request, but if you decide to integrate it please don't overdo it, cause I know other projects which where rendered useless, cause the margins, icons, ... got to small on the iPhone SE 1.

@dsarkar
Copy link
Member

dsarkar commented Jun 24, 2021

@Pe-te Thanks for contributing here.
Regarding CovPass, this is the corresponding repo: https://github.com/Digitaler-Impfnachweis


Corona-Warn-App Open Source Team

@dsarkar dsarkar added in review Moderators are investigating how to best proceed with the issue enhancement Improvement of an existing feature labels Jun 24, 2021
@Pe-te
Copy link
Author

Pe-te commented Jun 25, 2021

I generally do support this request, but if you decide to integrate it please don't overdo it, cause I know other projects which where rendered useless, cause the margins, icons, ... got to small on the iPhone SE 1.

First I didn't want to share a screenshot because someone might steal my code 😛 but now I can't because they are both gone after the 2.4.2 update? 😢

I think the problem was just a lot of empty space, so need to play with font or image sizes. Think the easiest way to detect those devices is to go by sceen width smaller than X, don't remember the value or which project I used it in. Think it was this simple check:
UIScreen.main.bounds.size.width <= 320
source: https://stackoverflow.com/a/51264446

@Pe-te
Copy link
Author

Pe-te commented Jun 25, 2021

Just realized that certificates are handled different now, see #3015

So on the startpage I don't have a problem anymore because I use the vaccination certificate. Someone with tests might still have it.

On the detail page it is still relevant I think, would be great to see the valid until without scrolling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature in review Moderators are investigating how to best proceed with the issue
Projects
None yet
Development

No branches or pull requests

3 participants