Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Plex #4415

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Adding Plex #4415

wants to merge 5 commits into from

Conversation

regg00
Copy link

@regg00 regg00 commented Nov 27, 2024

Changes

  • Added the plex.yaml service
  • Added the plex.svg logo

Issues

@peaklabs-dev
Copy link
Member

I am not very familiar with Plex, but why do we need all these port mappings?

@peaklabs-dev peaklabs-dev self-assigned this Nov 27, 2024
@peaklabs-dev peaklabs-dev added ⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for feedback Issues awaiting a response from the author. labels Nov 27, 2024
@regg00
Copy link
Author

regg00 commented Nov 27, 2024

@peaklabs-dev Here's the documentation from Plex: https://support.plex.tv/articles/201543147-what-network-ports-do-i-need-to-allow-through-my-firewall/

The most important port to make sure your firewall allows is the main TCP port the Plex Media Server uses for communication:

TCP: 32400 (access to the Plex Media Server) [required]
The following additional ports are also used within the local network for different services:

UDP: 1900 (access to the Plex DLNA Server)
UDP: 5353 (older Bonjour/Avahi network discovery)
TCP: 8324 (controlling Plex for Roku via Plex Companion)
UDP: 32410, 32412, 32413, 32414 (current GDM network discovery)
TCP: 32469 (access to the Plex DLNA Server)

@peaklabs-dev
Copy link
Member

I think the other ports are more optional and only needed in very special cases, so I think it makes sense to remove all ports since the required port 32400 is handled by the reverse proxy.

@peaklabs-dev peaklabs-dev added 💤 Waiting for changes PRs awaiting changes from the author. and removed 💤 Waiting for feedback Issues awaiting a response from the author. labels Nov 27, 2024
@regg00
Copy link
Author

regg00 commented Nov 27, 2024

Fair enough. If someone's got an issue in the future, I'll simply add the required ports one by one.

@peaklabs-dev
Copy link
Member

Thanks. 2 more things, I just tried it and the healthcheck does not seem to work and also the devices section should be commented out by default as not everyone has a GPU on their server.

@regg00
Copy link
Author

regg00 commented Nov 27, 2024

That's weird, the healthcheck is working on my side:
image

As for the devices section, while I agree that not everybody has a GPU or iGPU, that option is widely used by the community and it's pretty much a default.
It also doesn't impact the service if the device listed is not available, so I think it's a sensible default value to have, but it's your call so let me know what you decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants