Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tgrade-tc-payments] Get rid of Period #498

Open
maurolacy opened this issue Jun 1, 2022 · 0 comments
Open

[tgrade-tc-payments] Get rid of Period #498

maurolacy opened this issue Jun 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@maurolacy
Copy link
Contributor

The Period enum was introduced for generality, but it's probably overkill / not needed.

Removing it, and sticking to a monthly period for payments will simplify both, contract initialisation, and more importantly, checking for the beginning of the period (no storage load needed, for a fixed type of period).
@maurolacy maurolacy added the enhancement New feature or request label Jun 1, 2022
@maurolacy maurolacy mentioned this issue Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maurolacy