Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new code ID discovery #782

Closed
abefernan opened this issue Jul 28, 2022 · 2 comments · Fixed by #832
Closed

Adapt to new code ID discovery #782

abefernan opened this issue Jul 28, 2022 · 2 comments · Fixed by #832
Assignees

Comments

@abefernan
Copy link
Collaborator

With the implementation of this tfi functionality (confio/tfi#81) the app should query the code IDs for CW20 and Trusted Token, instead of relying on hardcoded config

@maurolacy
Copy link
Contributor

Just to be clear: Even without this functionality, the app can query tfi-factory (using the Config query) to get the code_ids of token and trusted_token.

What confio/tfi#81 will allow is delegating the creation of these tokens to tfi-factory.

@abefernan
Copy link
Collaborator Author

Ah, I understand. But the reason we'd want that is to use the same admin address as pair creation, set during factory instantiation, no? I'm not sure if any contract that uses other contracts should expose all the functionality from the inner contracts. Maybe we can just expose the admin address from the factory? Not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants