Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task poll update v2 #328

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Task poll update v2 #328

merged 7 commits into from
Dec 10, 2024

Conversation

v1r3n
Copy link
Collaborator

@v1r3n v1r3n commented Dec 9, 2024

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR
Improves the overall mechanism of how polling works.
Also, add sync apis

@v1r3n v1r3n requested a review from jmigueprieto December 9, 2024 06:00
jmigueprieto
jmigueprieto approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jmigueprieto jmigueprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1r3n v1r3n merged commit 1259a4a into main Dec 10, 2024
8 checks passed
@v1r3n v1r3n deleted the task_poll_update_v2 branch December 10, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmigueprieto jmigueprieto jmigueprieto approved these changes

Assignees

@v1r3n v1r3n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1r3n @jmigueprieto