Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spyder contains invalid json #274

Open
2 tasks done
baszalmstra opened this issue Nov 9, 2024 · 1 comment
Open
2 tasks done

spyder contains invalid json #274

baszalmstra opened this issue Nov 9, 2024 · 1 comment
Labels
type::bug describes erroneous operation, use severity::* to classify the type

Comments

@baszalmstra
Copy link

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

https://github.com/conda-forge/spyder-feedstock/blob/1c33270a40c7910c8207262274653a3491e93c83/recipe/spyder-menu.json#L160-L175

The above linked json file does not match the menuinst schema but it is not properly linted. According to the schema the highlighted section should contain a name, description and command which it doesnt. Only the win section contains it.

(Also the spyder json file refers to a non-existing schema)

Tagging @jaimergp and @mrclary as requested by jaime.

Conda Info

Not applicable

Conda Config

Not applicable

Conda list

Not applicable

Additional Context

No response

@baszalmstra baszalmstra added the type::bug describes erroneous operation, use severity::* to classify the type label Nov 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Nov 9, 2024
@mrclary
Copy link

mrclary commented Nov 9, 2024

According to the schema the highlighted section should contain a name, description and command which it doesnt. Only the win section contains it.

@baszalmstra, thanks for alerting me to this issue. If any tags are placed outside the windows platform section, then this additional shortcut is also created on all other platforms, which we do not want.

@jaimergp, to be fully compliant with the schema, should we create a separate json file for this shortcut, and only include it in windows builds? Or is there a bug because the platforms listed do not limit which shortcuts are created? This is not clear to me since platforms is also required.

Also the spyder json file refers to a non-existing schema

To which schema should it refer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants