Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BotConfig to regro/cf-scripts and use it in conda-smithy #1893

Open
isuruf opened this issue Mar 26, 2024 · 9 comments · May be fixed by #1894
Open

Move BotConfig to regro/cf-scripts and use it in conda-smithy #1893

isuruf opened this issue Mar 26, 2024 · 9 comments · May be fixed by #1894

Comments

@isuruf
Copy link
Member

isuruf commented Mar 26, 2024

I think it makes sense for the BotConfig to live in regro/cf-scripts

cc @beckermr, @ytausch, @xhochy, @jaimergp

@beckermr
Copy link
Member

💯 agreed, but no time right now.

@ytausch
Copy link
Contributor

ytausch commented Mar 26, 2024

This sounds a bit dangerous because cf-scripts already depends on conda-smithy for access to the Pydantic schema (and also other things?). Making this change would introduce a circular dependency.

Are there any drawbacks of the current solution?

@isuruf
Copy link
Member Author

isuruf commented Mar 26, 2024

We could make another repo or just download one self-contained python file that lives in regro/cf-scripts.

It's a separation of concern issue. conda-smithy should not be the place where BotConfig lives because it does not use it. The place where the botconfig is used is cf-scripts. Another issue is that making changes in the bot should not have to wait on a conda-smithy release.

@beckermr
Copy link
Member

Yeah I agree @isuruf. More generally, the validation being done is useful, but it embeds our APIs in concrete when we typically have made much more fluid changes in the ecosystem.

@ytausch
Copy link
Contributor

ytausch commented Mar 26, 2024

How about moving the entire schema to a different package? This keeps the schema definition together (holding complexity low - I am a bit terrified by the "self-contained python file"), while still allowing more rapid iterations because only the different package would need to be released (I know conda-smithy releases are quite tedious).

@isuruf
Copy link
Member Author

isuruf commented Mar 26, 2024

That would require co-ordinating the release of conda-smithy and the new package. The whole point is to make the bot config be independently developed from conda-smithy.

@beckermr
Copy link
Member

A direct download from the bot repo seems totally fine for this purpose. We can do it when we refresh the static schema on disk in smithy. If the download fails, we just keep the old schema.

@jaimergp
Copy link
Member

In principle jsonschema allows us to refer to remote resources (even if discouraged). We could fetch the cf-scripts JSON schema from that repo and use the defintions in the conda-forge.yml schema.

@jaimergp jaimergp linked a pull request Apr 29, 2024 that will close this issue
@beckermr
Copy link
Member

I think that's the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants