Changed locations for Drupal module and theme types

[ricardjp]

In a Drupal project the modules directory is reserved for core module files. Custom or contributed modules should be placed in their own subdirectory of the sites/all/modules directory.

The same is true for themes which should be placed in their own subdirectory of the sites/all/themes directory.

In my humble opinion the DrupalInstaller should reflect those coding guidelines.

Thx.

[shama]

Thanks! But have a look at #15 and #36. The locations for Drupal are intentional as it allows for multisite setups. You composer.json should be located in the sites/all/ folder.

[shama]

Since this seems to be a much requested change. I wonder if it would be possible to detect if the folder sites/all/ is relative to the composer.json then assume it is a single site and prepend sites/all/ to the install path.

@RobLoach As my go to Drupal expert, does that sound sensible?

[RobLoach]

Yeah, hardcoding "sites/all" here might not be the optimal solution. Using "modules", "themes" and "profiles", it allows supporting having composer.json in sites/all, sites/example.com, etc. Not to mention it would be future-proof with Drupal 8's defining its own composer.json.

Detecting where the Drupal root is an interesting idea. I got some of that working at DrupalInstaller.php. This was before Baton was highly adopted. Might be a good idea to move some of that over into the Composer Installers' Drupal installer.

Any thoughts on how the integration would look?

Thanks @ricardjp and @shama!

[lapistano]

I also do not like the circumstance (like mentioned in #15 & #36) to put the composer.json in /sites/all. For single site projects I keep the composer,json in the project root and use the "extra" branch of the composer/installers to relocate the 'installer-paths'. E.g.:

<--- Snip -->

"extra": {
        "installer-paths": {
            "sites/all/modules/{$name}/": [
                "drupal/imagefield_crop",
                "drupal/cck"
            ]
        }
    }

<--- Snip -->

At least for me this is working well.

[shama]

Submitted the Drupal auto-detect as a new issue #44. Thanks!