-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: to replace fs.access with fs.exist #1890
base: master
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 147 147
Lines 5057 5057
Branches 1375 1375
=======================================
Hits 4792 4792
Misses 262 262
Partials 3 3 ☔ View full report in Codecov by Sentry. |
@@ -6,6 +6,15 @@ import yargs from 'yargs' | |||
|
|||
import CsvParserDiscountCode from './main' | |||
|
|||
const doesFileExist = (filePath) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little observation, it will be nice if we can add a simple unit test to test this function.
Also, to make the testing easier, I will suggest you move |
Relates to