Update category-exporter.md #1888
Conversation
We'd like to update the script for category exporter a bit, based on the issues the customer in this ticket https://commercetools.atlassian.net/browse/SUPPORT-24058 had.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1888 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 147 147
Lines 5057 5057
Branches 1375 1375
=======================================
Hits 4792 4792
Misses 262 262
Partials 3 3 ☔ View full report in Codecov by Sentry. |
| @@ -61,10 +61,10 @@ const options = { | |||
| apiConfig: { | |||
| apiUrl: 'https://api.europe-west1.gcp.commercetools.com' | |||
| host: 'https://auth.europe-west1.gcp.commercetools.com' | |||
| project_key: 'PROJECT_KEY', | |||
| project_key: '<ProjectKey>', | |||
There was a problem hiding this comment.
Suggestion is based on the code in the support ticket.
| project_key: '<ProjectKey>', | |
| projectKey: '<ProjectKey>', |
There was a problem hiding this comment.
If projectKey: '<ProjectKey>' is correct, then we should probably check and update the code examples in other Exporter documents. I think they all use project_key: '<ProjectKey>'
| clientId: '*********', | ||
| clientSecret: '*********' | ||
| clientId: '<clientId>', | ||
| clientSecret: '<clientSecret>' | ||
| } | ||
| }, | ||
| accessToken: '123456yuhgfdwegh675412wefb4rgb', |
There was a problem hiding this comment.
Suggestion for consistency:
| accessToken: '123456yuhgfdwegh675412wefb4rgb', | |
| accessToken: '<accessToken>', |
We'd like to update the script for category exporter a bit, based on the issues the customer in this ticket https://commercetools.atlassian.net/browse/SUPPORT-24058 had.
@VineetKumarKushwaha please take a look and update anything you think should be updated about the script