Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sync-action): test adding newly master variant #1702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markus-azer
Copy link
Member

Summary

  • test to make sure that when adding newly master variant, it will be added as first addVariant action.

Description

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation
  • Type label for the PR

@markus-azer markus-azer requested review from ajimae and a team June 18, 2021 15:53
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #1702 (6300b2b) into master (6cd2a58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1702   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files         128      128           
  Lines        3427     3427           
  Branches      791      791           
=======================================
  Hits         3381     3381           
  Misses         42       42           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd2a58...6300b2b. Read the comment docs.

test('should add newly added masterVariant as first `addVariant` ', () => {
const actions = productsSync.buildActions(now, before)

expect(actions[0]).toEqual({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this redundant since we do an assertion on all the actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants