Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEC-139] Refactor React components "defaultProps" management #3676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CarlosCortizasCT
Copy link
Contributor

Summary

Update the way we manage default properties in React components.

Description

As part of the preparations for the upcoming update to the newest React version, we need to update how we manage components default properties and our current implementation will no longer be supported (reference).

// BEFORE
type TMyComponentProps = {
  message: string;
  size: string;
}

function MyComponent(props: TMyComponentProps) {
 ...
}

MyComponent.defaultProps = {
  size: 'big'
}


// AFTER
type TMyComponentProps = {
  message: string;
  size?: string; // <--- Note this property is now defined as optional
}

function MyComponent({ size = 'big', ...props }: TMyComponentProps) {
 ...
}

@CarlosCortizasCT CarlosCortizasCT added 🚧 Status: WIP Work in progress fe-chapter-rotation Tasks coming from frontend chapter work labels Dec 10, 2024
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: d8bc085

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 2:21pm
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 2:21pm

@CarlosCortizasCT CarlosCortizasCT removed the 🚧 Status: WIP Work in progress label Dec 10, 2024
@CarlosCortizasCT CarlosCortizasCT marked this pull request as ready for review December 10, 2024 14:46
@CarlosCortizasCT CarlosCortizasCT requested a review from a team as a code owner December 10, 2024 14:46
@CarlosCortizasCT CarlosCortizasCT self-assigned this Dec 10, 2024
@CarlosCortizasCT CarlosCortizasCT requested a review from a team December 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants