-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(README.md): add more comprehensive instructions for developing application kit bundles in readme #2346
Draft
ByronDWall
wants to merge
10
commits into
main
Choose a base branch
from
update-readme-developing-application-kit-bundles-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6486a18
chore(README.md): add more comprehensive instructions for developing …
ByronDWall 8d2d1fb
Update README.md
ByronDWall fc07510
chore(README.md): update docs for consistency/readablility
ByronDWall 1b53cf8
chore(README.md): fix typos and indentation in readme
ByronDWall b800d3c
chore(README.md): it's CTP_INITIAL_PROJECT_KEY, not CTP_INITIAL_PRODU…
ByronDWall 6c40c94
chore(README.md): update documentation with another step about removi…
33da242
chore(README.md): update documentation with another step about removi…
101b461
chore(README.md): update documentation with another step about removi…
jmcreasman 07ed52e
Merge branch 'update-readme-developing-application-kit-bundles-docs' …
ByronDWall 7fef0fa
chore(README.md): update README based on feedback and retrying runnin…
ByronDWall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all section can be removed to be honest. We can mention to check and ensure to have the
.env.local
file but I wouldn't document its content. Instead you can add more information and give hints in the template file itself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmenko
When you initially pull down the repo this is the result when you run yarn build:watch after adding the environment variables without running yarn build first.