Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Update react-router to v6 and history to v5 - abandoned #1575

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 15, 2020

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
history 4.10.1 -> 5.3.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the 🤖 Type: Dependencies Dependency updates or something similar label Jun 15, 2020
@vercel vercel bot temporarily deployed to Preview June 15, 2020 01:20 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2020

💥 No Changeset

Latest commit: 2cfe2ed

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/ir8lx0e1v
✅ Preview: https://merchant-center-application-kit-git-renovate-history-5x.commercetools.vercel.app

@tdeekens
Copy link
Contributor

As far as I can tell there is a conflict in types with the history-query-enhancer at history-query-enhancer/es/types.d.ts with the types it imports from history. I would say it's either blocked until solved upstream or we fork.

@renovate renovate bot force-pushed the renovate/history-5.x branch from e86f485 to d2feff0 Compare June 22, 2020 06:58
@vercel vercel bot temporarily deployed to Preview June 22, 2020 06:58 Inactive
@renovate renovate bot changed the title fix(deps): update dependency history to v5 Update dependency history to v5 Jun 26, 2020
@renovate renovate bot changed the title Update dependency history to v5 fix(deps): update dependency history to v5 Jun 30, 2020
@renovate renovate bot force-pushed the renovate/history-5.x branch from d2feff0 to 871a8fb Compare July 11, 2020 16:26
@vercel vercel bot temporarily deployed to Preview July 11, 2020 16:26 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from 871a8fb to 270e5e5 Compare July 14, 2020 12:49
@vercel vercel bot temporarily deployed to Preview July 14, 2020 12:49 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from 270e5e5 to d291242 Compare July 16, 2020 09:07
@vercel vercel bot temporarily deployed to Preview July 16, 2020 09:22 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from d291242 to 86b9483 Compare July 20, 2020 09:57
@vercel vercel bot temporarily deployed to Preview July 20, 2020 09:57 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from 86b9483 to 6cb2a34 Compare July 20, 2020 10:14
@vercel vercel bot temporarily deployed to Preview July 20, 2020 10:14 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from 6cb2a34 to 95ab2a8 Compare August 6, 2020 07:17
@vercel vercel bot temporarily deployed to Preview August 6, 2020 07:17 Inactive
@renovate renovate bot changed the title fix(deps): update dependency history to v5 Update dependency history to v5 Aug 6, 2020
@renovate renovate bot force-pushed the renovate/history-5.x branch from 95ab2a8 to 587f28c Compare August 10, 2020 09:31
@vercel vercel bot temporarily deployed to Preview August 10, 2020 09:31 Inactive
@renovate renovate bot changed the title Update dependency history to v5 fix(deps): update dependency history to v5 Aug 13, 2020
@renovate renovate bot force-pushed the renovate/history-5.x branch from 587f28c to 7a1c3a8 Compare August 17, 2020 07:02
@vercel vercel bot temporarily deployed to Preview August 17, 2020 07:03 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from 7a1c3a8 to dd743a9 Compare August 17, 2020 08:55
@vercel vercel bot temporarily deployed to Preview August 17, 2020 08:55 Inactive
@renovate renovate bot force-pushed the renovate/history-5.x branch from dd743a9 to 3f14d77 Compare August 19, 2020 20:23
@vercel vercel bot temporarily deployed to Preview August 19, 2020 20:23 Inactive
@emmenko
Copy link
Member

emmenko commented Aug 21, 2020

The history-query-enhancer package has not being maintained for the last 2 years. I think we can just "copy" over the implementation and make sure the types are compatible with history v5

@renovate renovate bot force-pushed the renovate/history-5.x branch from 3f14d77 to 7c0f999 Compare August 21, 2020 12:49
@vercel vercel bot temporarily deployed to Preview August 21, 2020 12:49 Inactive
@emmenko emmenko force-pushed the renovate/history-5.x branch from 7c0f999 to 54e38fd Compare August 21, 2020 14:09
@vercel vercel bot temporarily deployed to Preview August 21, 2020 14:09 Inactive
@emmenko
Copy link
Member

emmenko commented Aug 21, 2020

Alright, I migrated the enhanced history stuff.

However, we need to wait for react-router v6 to be released as well, as otherwise things won't properly work: https://github.com/ReactTraining/react-router/releases/tag/v6.0.0-beta.0

@emmenko emmenko marked this pull request as draft August 21, 2020 14:10
@emmenko emmenko changed the title fix(deps): update dependency history to v5 [Breaking] Update react-router to v6 and history to v5 Sep 11, 2020
@emmenko emmenko force-pushed the renovate/history-5.x branch from 54e38fd to 59652ea Compare September 11, 2020 15:42
@vercel vercel bot temporarily deployed to Preview September 11, 2020 15:42 Inactive
@emmenko
Copy link
Member

emmenko commented Sep 11, 2020

FYI: I took a look at react router v6. It will take a bit of an effort to migrate and document the changes, as they are quite substantial.

@emmenko emmenko force-pushed the renovate/history-5.x branch from 59652ea to 2cfe2ed Compare September 21, 2020 21:00
@vercel vercel bot temporarily deployed to Preview September 21, 2020 21:00 Inactive
@emmenko emmenko mentioned this pull request Sep 30, 2020
7 tasks
@emmenko emmenko mentioned this pull request Oct 26, 2020
8 tasks
@renovate
Copy link
Contributor Author

renovate bot commented Jan 5, 2021

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Base automatically changed from master to main February 2, 2021 16:59
@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title [Breaking] Update react-router to v6 and history to v5 [Breaking] Update react-router to v6 and history to v5 - abandoned Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants