-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Update react-router to v6 and history to v5 - abandoned #1575
base: main
Are you sure you want to change the base?
Conversation
💥 No ChangesetLatest commit: 2cfe2ed Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/ir8lx0e1v |
As far as I can tell there is a conflict in types with the history-query-enhancer at |
e86f485
to
d2feff0
Compare
d2feff0
to
871a8fb
Compare
871a8fb
to
270e5e5
Compare
270e5e5
to
d291242
Compare
d291242
to
86b9483
Compare
86b9483
to
6cb2a34
Compare
6cb2a34
to
95ab2a8
Compare
95ab2a8
to
587f28c
Compare
587f28c
to
7a1c3a8
Compare
7a1c3a8
to
dd743a9
Compare
dd743a9
to
3f14d77
Compare
The history-query-enhancer package has not being maintained for the last 2 years. I think we can just "copy" over the implementation and make sure the types are compatible with history v5 |
3f14d77
to
7c0f999
Compare
7c0f999
to
54e38fd
Compare
Alright, I migrated the enhanced history stuff. However, we need to wait for |
54e38fd
to
59652ea
Compare
FYI: I took a look at react router v6. It will take a bit of an effort to migrate and document the changes, as they are quite substantial. |
59652ea
to
2cfe2ed
Compare
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
This PR contains the following updates:
4.10.1
->5.3.0
Configuration
📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.