@commercetools/ts-client 2.0 throws javascript error on http error #761

mvantellingen · 2024-07-26T09:04:53Z

Describe the bug
I previously run into this issue: #647 but with the latest version (2.0) we now get the following error:

TypeError: Cannot read properties of undefined (reading 'error')
../../../node_modules/.pnpm/@[email protected][email protected]/node_modules/@commercetools/ts-client/dist/commercetools-ts-client.cjs.dev.js:1461:19

I think this is the relevant line

commercetools-sdk-typescript/packages/sdk-client-v3/src/client/client.ts

Line 179 in b7581b6

if (res.error) {

To Reproduce
Do a request which returns an error

The text was updated successfully, but these errors were encountered:

mvantellingen · 2024-07-26T09:05:42Z

PS. we (Lab Digital) have a shared slack channel, feel free to reach out to me.

Engerim · 2024-07-29T15:24:02Z

I see a similiar issue but only when I use the createQueueMiddleware then we ofc queue a lot of requests and when we exceed the concurrency value of 10 in our case, the res is undefined hte process failed, if I deactivate the queue it works

ajimae · 2024-08-05T13:20:41Z

PS. we (Lab Digital) have a shared slack channel, feel free to reach out to me.

Hi @mvantellingen

Thanks for reporting this issue. Can you provide me with more details on the request that caused this error? if possible a code snippet will also work.

Thanks

ajimae · 2024-08-05T13:23:25Z

I see a similiar issue but only when I use the createQueueMiddleware then we ofc queue a lot of requests and when we exceed the concurrency value of 10 in our case, the res is undefined hte process failed, if I deactivate the queue it works

Hi @Engerim

Can you provide a code snippet that caused this issue, in the mean time I will investigate it to see if I can reproduce it from my end.

Thanks once again for reporting this issue.

ajimae · 2024-08-06T14:42:58Z

Currently working to find the root cause of this issue and I can confirm this issue doesn't exist in version 1.0.0 of the @commercetools/ts-client package.

I will continue working to fix it.

Engerim · 2024-08-08T17:48:16Z

We are working just with a loop of promises where we send over 100 requests and in the promises and we use the concurrency middleware and set the value to 10 and it fails. it is just happening I will try on monday to replicate the issue in a smaller testcase

ajimae · 2024-08-08T19:03:41Z

Hi @Engerim,

We raised a PR to fix this issue, once it's merge and we release a new version, this issue should be fixed.

Thanks

ajimae · 2024-08-21T13:32:30Z

This is now fixed, please update to the latest version of the SDK. Thanks

miticm · 2024-09-09T07:23:09Z

Hi @ajimae, I am getting the error using the latest 2.0.4 version [0] TypeError: Cannot read properties of undefined (reading 'error') [0] at /node_modules/@commercetools/ts-client/dist/commercetools-ts-client.cjs.dev.js:1492:19 [0] at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
I am using the withAnonymousSessionFlow and performing some chained calls like this apiRoot .inStoreKeyWithStoreKeyValue({ storeKey: xxx" }) .me() .carts() .withId({ ID: cartId }) .post({ body: { version: version, actions: [myCartAddLineItemAction], }, }) .execute() and when an error occurs, the error above from the SDK will appear. when I was using the @commercetools/sdk-client-v2, it works fine, I am trying to migrate but have this issue

ajimae · 2024-09-09T08:12:52Z

Hi @miticm

I would like to know if you experience this error only on version 2.0.4. does it also occur in version prior to 2.0.4, can you check if this error also occur in version 2.0.3?

Also, I believe this issue is fixed here and a new patch version was released here as well.

You try this fixed version (2.0.2) and let us know if you still experience this error.

Thanks

miticm · 2024-09-10T02:27:17Z

Hi @ajimae,

I also experience this error in 2.0.3 and 2.0.2. I am not using the ConcurrentModificationMiddleware though, so I am not sure if the fix is relevant

Thanks

ajimae · 2024-09-10T07:13:27Z

Hi @miticm

Thanks for confirming the issue also exists in other versions of the SDK.

I will look into this and make a fix as soon as possible.

I will let you know, once it is done.

Thanks

ajimae · 2024-09-13T13:24:39Z

Hi @miticm

I have been struggling to reproduce this issue, please can you share the code and configs that triggers this issues?

Preferably the client and the function and methods you are calling for making requests.

Thank you

miticm · 2024-09-16T02:06:49Z

Hi @ajimae,

"@commercetools/checkout-browser-sdk": "^0.7.1",
"@commercetools/platform-sdk": "^7.13.0",
"@commercetools/ts-client": "^2.0.4",

here is the Client I use

export const getAnonymousSessionFlowApiRoot = ({
  token,
  refreshToken,
  expirationTime,
}: {
  token: string;
  refreshToken: string;
  expirationTime: number;
}): ApiRoot => {
  //AnonymousAuthMiddlewareOptions type not exist anymore in ts-client sdk
  const anonymousSession: AuthMiddlewareOptions = {
    host: oauthHost,
    projectKey,
    credentials: {
      clientId,
      clientSecret,
    },
    tokenCache: {
      get: () => {
        return {
          token,
          expirationTime,
          refreshToken,
        };
      },
      set: () => {},
    },
    scopes: [`manage_project:${projectKey}`],
  };

  const client = new ClientBuilder().withAnonymousSessionFlow(anonymousSession).withHttpMiddleware(httpOptions).build();
  return createApiBuilderFromCtpClient(client).withProjectKey({ projectKey });
};

and here is a call example

    apiRoot
    .inStoreKeyWithStoreKeyValue({ storeKey: "au-store" })
    .me()
    .activeCart()
    .get({
      queryArgs: {
        expand: "shippingInfo.shippingMethod",
      },
    })
    .execute();

and it will produce results with TypeError like these

[0] TypeError: Cannot read properties of undefined (reading 'error')
[0]     at /node_modules/@commercetools/ts-client/dist/commercetools-ts-client.cjs.dev.js:1492:19
[0]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[0]  POST /api/commercetool/cart/activeCart 200 in 1005ms

[0] TypeError: Cannot read properties of undefined (reading 'error')
[0]     at /node_modules/@commercetools/ts-client/dist/commercetools-ts-client.cjs.dev.js:1492:19
[0]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[0]  POST /api/commercetool/cart/addToCart 500 in 1810ms

ajimae · 2024-09-16T08:25:00Z

Hi @ajimae,

"@commercetools/checkout-browser-sdk": "^0.7.1",
"@commercetools/platform-sdk": "^7.13.0",
"@commercetools/ts-client": "^2.0.4",

here is the Client I use

export const getAnonymousSessionFlowApiRoot = ({
  token,
  refreshToken,
  expirationTime,
}: {
  token: string;
  refreshToken: string;
  expirationTime: number;
}): ApiRoot => {
  //AnonymousAuthMiddlewareOptions type not exist anymore in ts-client sdk
  const anonymousSession: AuthMiddlewareOptions = {
    host: oauthHost,
    projectKey,
    credentials: {
      clientId,
      clientSecret,
    },
    tokenCache: {
      get: () => {
        return {
          token,
          expirationTime,
          refreshToken,
        };
      },
      set: () => {},
    },
    scopes: [`manage_project:${projectKey}`],
  };

  const client = new ClientBuilder().withAnonymousSessionFlow(anonymousSession).withHttpMiddleware(httpOptions).build();
  return createApiBuilderFromCtpClient(client).withProjectKey({ projectKey });
};

and here is a call example

    apiRoot
    .inStoreKeyWithStoreKeyValue({ storeKey: "au-store" })
    .me()
    .activeCart()
    .get({
      queryArgs: {
        expand: "shippingInfo.shippingMethod",
      },
    })
    .execute();

and it will produce results with TypeError like these

[0] TypeError: Cannot read properties of undefined (reading 'error')
[0]     at /node_modules/@commercetools/ts-client/dist/commercetools-ts-client.cjs.dev.js:1492:19
[0]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[0]  POST /api/commercetool/cart/activeCart 200 in 1005ms

[0] TypeError: Cannot read properties of undefined (reading 'error')
[0]     at /node_modules/@commercetools/ts-client/dist/commercetools-ts-client.cjs.dev.js:1492:19
[0]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[0]  POST /api/commercetool/cart/addToCart 500 in 1810ms

Hi @miticm,

I have seen the snippets.

I will take a look at it today and hopefully get it fixed.

Thanks

ajimae · 2024-09-17T12:24:26Z

Hi @miticm,

I have been on this issue for sometime now and I still couldn't reproduce this on my end.

The following is the snippet I used for testing:

const { ClientBuilder } = require('@commercetools/ts-client');
const { createApiBuilderFromCtpClient } = require('@commercetools/platform-sdk')
const fetch = require('node-fetch');

function _tokenCache(val) {
  let initialVal = val
  return {
    get() {
      return initialVal
    },
    set(value) {
      initialVal = value
    }
  }
}

const tokenCache = _tokenCache({ token, expirationTime })
const projectKey = process.env.CTP_PROJECT_KEY;

const authMiddlewareOptions = {
  projectKey,
  host: 'https://auth.europe-west1.gcp.commercetools.com',
  credentials: {
    clientId: process.env.CTP_CLIENT_ID,
    clientSecret: process.env.CTP_CLIENT_SECRET
  },
  tokenCache,
  scopes: [`manage_project:${projectKey}`],
  httpClient: fetch
}

const httpMiddlewareOptions = {
  host: 'https://api.europe-west1.gcp.commercetools.com',
  // includeOriginalRequest: true,
  // maskSensitiveHeaderData: true,
  httpClient: fetch
}

const client = new ClientBuilder()
  .withProjectKey(projectKey)
  .withAnonymousSessionFlow(authMiddlewareOptions)
  .withHttpMiddleware(httpMiddlewareOptions)
  .build();

const apiRoot = createApiBuilderFromCtpClient(client).withProjectKey({ projectKey });

async function exec() {
  // create store
  // return apiRoot
  //   .stores()
  //   .post({ body: { key: 'xxx-test-key' } })
  //   .execute();

  // get carts
  // return apiRoot
  //   .inStoreKeyWithStoreKeyValue({ storeKey: 'xxx-test-key' })
  //   .me()
  //   .carts()
  //   .get({
  //     queryArgs: {
  //       expand: 'shippingInfo.shippingMethod',
  //     },
  //   }).execute();

  // create a cart in store
  // return apiRoot
  //   .inStoreKeyWithStoreKeyValue({ storeKey: 'xxx-test-key' })
  //   .me()
  //   .carts()
  //   .post({
  //     body: {
  //       currency: 'EUR'
  //     }
  //   }).execute();

  // get in-store active cart
  return apiRoot
    .inStoreKeyWithStoreKeyValue({ storeKey: 'xxx-test-key' })
    .me()
    .activeCart()
    .get({
      queryArgs: {
        expand: 'shippingInfo.shippingMethod'
      }
    }).execute();
}

exec()
  .then(data => {
    console.log(data)
  }).catch(e => {
    console.error(e)
  });

This is the error response when the active cart is not found.

Click to expand

 NotFound: URI not found: /{projectKey}/in-store/key=xxx-test-key/me/active-cart
    at createError (/Users/****/workspace/commercetools-sdk-typescript/packages/sdk-client/dist/commercetools-sdk-client-v2.cjs.dev.js:769:29)
    at /Users/****/workspace/commercetools-sdk-typescript/packages/sdk-client/dist/commercetools-sdk-client-v2.cjs.dev.js:940:25
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 404,
  statusCode: 404,
  status: 404,
  originalRequest: {
    baseUri: 'https://api.europe-west1.gcp.commercetools.com',
    method: 'GET',
    uriTemplate: '/{projectKey}/in-store/key={storeKey}/me/active-cart',
    pathVariables: {
      projectKey: '{projectKey}',
      storeKey: 'xxx-test-key'
    },
    headers: { Authorization: 'Bearer ********' },
    queryParams: undefined,
    uri: '/{projectKey}/in-store/key=xxx-test-key/me/active-cart'
  },
  retryCount: 0,
  headers: [Object: null prototype] {},
  body: {
    statusCode: 404,
    message: 'No active cart exists.',
    errors: [ [Object] ]
  }
}

I would suggest you do one or all the following to see if the issue still persists.

Create a new simple and fresh project from scratch.
Make a fresh install of the @commercetools/ts-client SDK.
Properly check your environment variables
If possible try out a new auth flow e.g ClientCredentialsFlow.
Try out the old client version to see if it works as expected.
Add a resolution field to your package.json to ensure the @commercetools/ts-client resolves to version 2.0.3 or newer.
Update node version.

Thank you.

ajimae · 2024-09-18T11:27:12Z

Hi @miticm,

I am now able to reproduce this issue. The issue occurs when the execute() in the SDK is called concurrently.

I will raise a PR soon to fix this issue.

Thank you.

ajimae · 2024-09-18T13:05:07Z

This should now be fixed

Don't hesitate to reopen if the issue still persists.

Thank you.

miticm · 2024-09-19T02:16:21Z

Hi @ajimae, the issue still exists after upgrading the packages

ajimae · 2024-10-09T09:14:28Z

Hi,

We made almost a complete rewrite of the internal logic of the v3 SDK, we just made a new (v2.1.0) release.

You can try to update to the latest version and let us know if this issue still exists.

Thank you.

mvantellingen added the bug Something isn't working label Jul 26, 2024

ajimae self-assigned this Aug 5, 2024

ajimae mentioned this issue Aug 8, 2024

SUPPORT-27819 fix concurrent lock acquiring when concurrently fetching token #777

Merged

ajimae closed this as completed Aug 21, 2024

ajimae reopened this Sep 9, 2024

ajimae mentioned this issue Sep 18, 2024

[Fix][DEVX-461] Concurrency issue in TypeScript SDK #807

Merged

2 tasks

ajimae closed this as completed Sep 18, 2024

ajimae reopened this Sep 19, 2024

ajimae mentioned this issue Oct 7, 2024

Restructure TS Client V3 #814

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@commercetools/ts-client 2.0 throws javascript error on http error #761

@commercetools/ts-client 2.0 throws javascript error on http error #761

mvantellingen commented Jul 26, 2024

mvantellingen commented Jul 26, 2024

Engerim commented Jul 29, 2024

ajimae commented Aug 5, 2024

ajimae commented Aug 5, 2024

ajimae commented Aug 6, 2024 •

edited

Loading

Engerim commented Aug 8, 2024

ajimae commented Aug 8, 2024

ajimae commented Aug 21, 2024

miticm commented Sep 9, 2024 •

edited

Loading

ajimae commented Sep 9, 2024 •

edited

Loading

miticm commented Sep 10, 2024

ajimae commented Sep 10, 2024

ajimae commented Sep 13, 2024

miticm commented Sep 16, 2024

ajimae commented Sep 16, 2024

ajimae commented Sep 17, 2024

ajimae commented Sep 18, 2024

ajimae commented Sep 18, 2024

miticm commented Sep 19, 2024

ajimae commented Oct 9, 2024

@commercetools/ts-client 2.0 throws javascript error on http error #761

@commercetools/ts-client 2.0 throws javascript error on http error #761

Comments

mvantellingen commented Jul 26, 2024

mvantellingen commented Jul 26, 2024

Engerim commented Jul 29, 2024

ajimae commented Aug 5, 2024

ajimae commented Aug 5, 2024

ajimae commented Aug 6, 2024 • edited Loading

Engerim commented Aug 8, 2024

ajimae commented Aug 8, 2024

ajimae commented Aug 21, 2024

miticm commented Sep 9, 2024 • edited Loading

ajimae commented Sep 9, 2024 • edited Loading

miticm commented Sep 10, 2024

ajimae commented Sep 10, 2024

ajimae commented Sep 13, 2024

miticm commented Sep 16, 2024

ajimae commented Sep 16, 2024

ajimae commented Sep 17, 2024

ajimae commented Sep 18, 2024

ajimae commented Sep 18, 2024

miticm commented Sep 19, 2024

ajimae commented Oct 9, 2024

ajimae commented Aug 6, 2024 •

edited

Loading

miticm commented Sep 9, 2024 •

edited

Loading

ajimae commented Sep 9, 2024 •

edited

Loading