Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JustinBeckwith/linkinator-action node 20 update #1971

Open
gabriele-ct opened this issue Apr 10, 2024 · 1 comment
Open

JustinBeckwith/linkinator-action node 20 update #1971

gabriele-ct opened this issue Apr 10, 2024 · 1 comment

Comments

@gabriele-ct
Copy link
Contributor

gabriele-ct commented Apr 10, 2024

Due to the coming deprecation of node 16 based actions on gh, we need to find a way to upgrade JustinBeckwith/linkinator-action action. So far (10 April) it doesn't seem to have a node 20 version but there is an issue related to that.
Options:

  • The action gets updated in reasonable time
  • We fork the action and update it ourselves
  • We explore the possibility of using linkchecker instead.
@nkuehn
Copy link
Collaborator

nkuehn commented Apr 10, 2024

The action itself has only very few javascript code. The most natural option is missing from your list: Open a PR with the fix ("forking" is necessary int he technical sense but it's not to maintain a fork).

My guess: Nothing is needed to be changed except declaring it 20 compatible.

linkchecker will not do the job because it does not cover on-page anchors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants