macos: use /tmp instead of /dev/shm #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
requested changes
Nov 28, 2024
|
I will , sorry ! I’ve been busy with MADS rewrite in SP |
adeebshihadeh
requested changes
Dec 10, 2024
| @@ -383,15 +390,15 @@ TEST_CASE("1 publisher, 1 slow subscriber", "[integration]") | |||
| msgq_msg_close(&msg1); | |||
| } | |||
| } | |||
|
|
|||
Comment on lines
+24
to
+28
| #ifdef __APPLE__ | ||
| std::string full_path = "/tmp/"; | ||
| #else | ||
| std::string full_path = "/dev/shm/"; | ||
| #endif |
There was a problem hiding this comment.
this should be pulled out
Comment on lines
+90
to
+93
| #ifdef __APPLE__ | ||
| std::string full_path = "/tmp/"; | ||
| #else | ||
| std::string full_path = "/dev/shm/"; |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In macos a lot of the tests in OP still seem to rely on "/dev/shm" so this, alongside with commaai/openpilot#34097 should unblock those cases