Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 Replace React with Solid #69

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

#42 Replace React with Solid #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1f88989
refactor: replace react with solid
uanandaraja Nov 23, 2024
dbf9785
refactor react components to solid
uanandaraja Nov 23, 2024
d446110
refactor main guides to solid
uanandaraja Nov 23, 2024
e12af5d
Merge pull request #1 from uanandaraja/refactor/move-to-solid
uanandaraja Nov 23, 2024
4e2671b
fix: make iconstyle default
uanandaraja Nov 23, 2024
321c52b
Merge pull request #2 from uanandaraja/fix/uninvert-iconstyle
uanandaraja Nov 23, 2024
298791d
fix: typo
uanandaraja Nov 23, 2024
995fa90
perf: use show component
uanandaraja Nov 23, 2024
ac2bce2
perf: memoize ui state
uanandaraja Nov 23, 2024
14c8957
perf: load plausible async
uanandaraja Nov 23, 2024
6cf316e
perf: preload manifest
uanandaraja Nov 23, 2024
f972d4b
Merge pull request #3 from uanandaraja/refactor/perf-optimization
uanandaraja Nov 23, 2024
e3ab108
perf: move steps and errors to constants
uanandaraja Nov 23, 2024
42a0966
Merge pull request #4 from uanandaraja/refactor/move-steps-and-errors
uanandaraja Nov 23, 2024
5a58db8
refactor: migrate testing library to solidjs
uanandaraja Nov 23, 2024
b81850f
Merge pull request #5 from uanandaraja/refactor/test-lib-solid
uanandaraja Nov 23, 2024
ff1fff2
fix: sparse assumption on manifest test
uanandaraja Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bun.lockb
View file
Open in desktop
Binary file not shown.
5 changes: 0 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,5 @@
<body>
<div id="root"></div>
<script type="module" src="/src/main.jsx"></script>
<script
defer
data-domain="flash.comma.ai"
src="https://plausible.io/js/script.outbound-links.js"
></script>
</body>
</html>
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
"jssha": "^3.3.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"solid-js": "^1.8.15",
"xz-decompress": "^0.2.1"
},
"devDependencies": {
"@solidjs/testing-library": "^0.8.10",
"@tailwindcss/typography": "^0.5.13",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/react": "^15.0.7",
Expand All @@ -39,6 +41,7 @@
"postcss": "^8.4.38",
"tailwindcss": "^3.4.3",
"vite": "^5.2.12",
"vite-plugin-solid": "^2.10.1",
"vite-svg-loader": "^5.1.0",
"vitest": "^1.6.0"
}
Expand Down
25 changes: 16 additions & 9 deletions src/app/App.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
import { Suspense } from 'react'
import { expect, test } from 'vitest'
import { render, screen } from '@testing-library/react'
import { describe, expect, test } from "vitest";
import { render, screen } from "@solidjs/testing-library";
import { Suspense } from "solid-js";
import App from ".";

import App from '.'

test('renders without crashing', () => {
render(<Suspense fallback="loading"><App /></Suspense>)
expect(screen.getByText('flash.comma.ai')).toBeInTheDocument()
})
describe("App", () => {
test("renders without crashing", () => {
render(() => (
<div>
<Suspense fallback="loading">
<App />
</Suspense>
</div>
));
expect(screen.getByText("flash.comma.ai")).toBeInTheDocument();
});
});
Loading