initial fixes for reactmapgl7 #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Navigation/index.js
Outdated
| latitude: viewport.latitude, | ||
| zoom: viewport.zoom, | ||
| }} | ||
| onLoad={e => this.geolocateControlRef.current && this.geolocateControlRef.current.trigger()} |
There was a problem hiding this comment.
Could we avoid requesting the user's location until they click on the map? That would preserve the current behavior
There was a problem hiding this comment.
Yes, we can change it to onClick.
| latitude: viewport.latitude, | ||
| zoom: viewport.zoom, | ||
| }} | ||
| onLoad={e => this.geolocateControlRef.current && this.geolocateControlRef.current.trigger()} | ||
| onViewportChange={this.viewportChange} | ||
| onContextMenu={null} | ||
| mapStyle={MAP_STYLE} | ||
| width="100%" | ||
| height="100%" | ||
| onNativeClick={this.focus} |
There was a problem hiding this comment.
The map height should increase when the user interacts with it, but this callback doesn't seem to be called anymore
There was a problem hiding this comment.
Yes, it seems like the height property is now part of mapStyle, but I'm not sure how it translates visually for the navigation map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of updating to
react-map-gl v7is two fold:onErrorforGeolocateControl, which can help in Notify when camera/location access is blocked #338 and even browser events which are once denied to notify user of further actions.Current code compiles and bugs with the drag events on both navigation and drive maps are resolved. I wasn't able to dive into onViewportChange since I wasn't able to see the features affected in the demo version. Dead code parameters can be removed once the API migration is complete.