Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Loading DBC sometimes requires clicking button multiple times #111

Open
pd0wm opened this issue Feb 21, 2022 · 3 comments
Open

Loading DBC sometimes requires clicking button multiple times #111

pd0wm opened this issue Feb 21, 2022 · 3 comments
Labels

Comments

@pd0wm
Copy link
Contributor

pd0wm commented Feb 21, 2022

No description provided.

@pd0wm pd0wm added the bug label Feb 21, 2022
@jwooning
Copy link
Contributor

Can't seem to reproduce, I'm assuming this is the button in the dbc selection modal?
The loading takes a while, maybe it's just loading? In that case I can add a spinner or something.

@adeebshihadeh
Copy link
Contributor

I've hit this too, and I think it's just general UI unresponsiveness. For this specific issue, maybe disable the button and change the text to "Loading..."? Can we also do anything to keep the UI responsive? The UI seems to lock up pretty frequently.

@jwooning
Copy link
Contributor

This might actually be fixed now with 9ca2e4e, adding a loading state wasn't easy to do in the end, it seems that the slow part is actually calling the onClick handler, I guess the main thread is just busy with something, which I don't think is easy to fix unfortunately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants